Allow using hashed IP addresses #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the option of hashing IP addresses before storing them. Similar to #7 this avoids problems when using a filesystem-based cache implementation, but also covers IPv6 addresses (as opposed to the IPv4-only covered by #7). The library's base functionality remains unchanged; the new feature is implemented via an opt-in configuration setting.
Using hashing instead of a regex-replacement has the added benefit of anonymizing user's addresses inside the cache and thus being compliant with data privacy norms.
The salted MD5 hashing algorithm used is a compromise between relative security of these user data and speed in order not to become a bottleneck.
I've added tests for both the default behaviour and the new behaviour with IP hashing enabled. In doing so, I've refactored the tests a little and fixed the PSR-4 root declaration for the test namespace.