Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update clang-format rules (clang-format-19) #6450

Draft
wants to merge 5 commits into
base: base
Choose a base branch
from

Conversation

zach2good
Copy link
Contributor

@zach2good zach2good commented Nov 21, 2024

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Of note/TODO:

  • Death to all clang-format on/off blocks
  • We now live in a west const world
  • I'm still fighting with macros
  • I'm still fighting with things like settings::overloaded
  • I'm still fighting with conditional reflowing, etc.
  • I'm still fighting with type and assignment alignment
  • I decided to keep namespace nesting
  • Spaces around simple {} etc.
  • Make it easy to setup the tooling for Windows/Linux/OSX, have it work easily/automatically in VSCode
  • Make it hard to use the wrong versions of clang-format, etc.
  • Update CI

@zach2good
Copy link
Contributor Author

#6423

@zach2good zach2good force-pushed the update_clang_format branch 2 times, most recently from adc23a0 to fd110c5 Compare November 21, 2024 14:59
@zach2good zach2good force-pushed the update_clang_format branch from 26613fd to 74fe7e9 Compare December 9, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant