Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Cache augment data on startup #6445

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Core: Cache augment data on startup #6445

merged 1 commit into from
Nov 20, 2024

Conversation

zach2good
Copy link
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Closes #6441

We absolutely shouldn't be querying for static data at runtime... ever... for any reason... lol

Also while looking at this, we seem to store the data in the db sanely, but we're doing some sort of sillybuggers about negative values once we load it? Will need some investigation. Did this quickly on my lunch break, need to fire this up and test on my Windows machine before merging.

@WinterSolstice8
Copy link
Member

I cherry picked this in, seems to work fine
image

@zach2good zach2good merged commit f81df2a into base Nov 20, 2024
11 of 12 checks passed
@zach2good zach2good deleted the cache_augments branch November 20, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔨 Cache Augments at startup
3 participants