feat(YouTube/Seekbar components): remove `Enable high quality thumbna…

…ils` setting inotia00/ReVanced_Extended#2460
Laitinlok · Nov 6, 2024 · 065854e · 065854e
1 parent 200e2b8
commit 065854e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/src/main/kotlin/app/revanced/patches/youtube/player/seekbar/SeekbarComponentsPatch.kt b/src/main/kotlin/app/revanced/patches/youtube/player/seekbar/SeekbarComponentsPatch.kt
@@ -218,10 +218,11 @@ object SeekbarComponentsPatch : BaseBytecodePatch(
 
         // region patch for high quality thumbnails
 
-        SeekbarThumbnailsQualityFingerprint.injectLiteralInstructionBooleanCall(
-            45399684,
-            "$PLAYER_CLASS_DESCRIPTOR->enableHighQualityFullscreenThumbnails()Z"
-        )
+        // TODO: This will be added when support for newer YouTube versions is added.
+        // SeekbarThumbnailsQualityFingerprint.injectLiteralInstructionBooleanCall(
+        //     45399684,
+        //     "$PLAYER_CLASS_DESCRIPTOR->enableHighQualityFullscreenThumbnails()Z"
+        // )
 
         // endregion
 

diff --git a/src/main/resources/youtube/settings/xml/revanced_prefs.xml b/src/main/resources/youtube/settings/xml/revanced_prefs.xml
@@ -454,9 +454,6 @@
             <!-- SETTINGS: RESTORE_OLD_SEEKBAR_THUMBNAILS
             <SwitchPreference android:title="@string/revanced_restore_old_seekbar_thumbnails_title" android:key="revanced_restore_old_seekbar_thumbnails" android:summaryOn="@string/revanced_restore_old_seekbar_thumbnails_summary_on" android:summaryOff="@string/revanced_restore_old_seekbar_thumbnails_summary_off" />SETTINGS: RESTORE_OLD_SEEKBAR_THUMBNAILS -->
 
-            <!-- SETTINGS: SEEKBAR_COMPONENTS
-            <SwitchPreference android:title="@string/revanced_enable_seekbar_thumbnails_high_quality_title" android:key="revanced_enable_seekbar_thumbnails_high_quality" android:summaryOn="@string/revanced_enable_seekbar_thumbnails_high_quality_summary_on" android:summaryOff="@string/revanced_enable_seekbar_thumbnails_high_quality_summary_off" />SETTINGS: SEEKBAR_COMPONENTS -->
-
             <!-- SETTINGS: ENABLE_CAIRO_SEEKBAR
             <PreferenceCategory android:title="@string/revanced_preference_category_experimental_flag" android:layout="@layout/revanced_settings_preferences_category"/>
             <SwitchPreference android:title="@string/revanced_enable_cairo_seekbar_title" android:key="revanced_enable_cairo_seekbar" android:summaryOn="@string/revanced_enable_cairo_seekbar_summary_on" android:summaryOff="@string/revanced_enable_cairo_seekbar_summary_off" />SETTINGS: ENABLE_CAIRO_SEEKBAR -->