[MAN-209] Create test suite #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntracts namespace
…e-device-proxy (wip)
…the sake of completeness
…ded even in the case of missing-symbols-errors this is done for consistency's sake
…e getting raised properly
…t for the sake of consistency in the case we get missing symbols errors
…nged
it was causing the state-changed event to be fired with the old and new state passed in each other's place
… now also exclude ArgumentExceptions
in the case of timeout we now trigger (for the sake consistency) a state-changed event with the new state set to Failed
…al/xamarin-nordic-mcumgr into ksidirop/MAN-209-create-test-suite # Conflicts: # Laerdal.McuMgr/Shared/FileDownloader/FileDownloader.cs # Laerdal.McuMgr/Shared/FileUploader/FileUploader.cs
…sets on both android and ios
…f having the remote file path reported by the native callbacks themselves
…parameter to the state changed event this should help when multi-uploading files
this is still wip and doesnt cover everything yet
…is call to never return when a download would be successful
…ld on both ShouldThrowTimeoutException_GivenTooSmallTimeout() methods [skip ci]
…oadCompletedEventArgs.Resource the event-args now have a new property .Resource which corresponds to the remote file that was successfully downloaded
…veFileDownloader()): enrich test to account for DownloadCompletedEventArgs.Resource
…et completion timeout to 5secs old was 0.5 secs which was causing problems in azure pipelines
… with the new mechanism
…ertise the state in which the error occurred in for the sake of clarity
and use it to change the state to Cancelling right when Cancel() gets invoked
…ption by adding a placeholder message to it instead of passing 'null'
…chanism to have it bail out forcibly if and when the cancellation request doesn't get serviced within 2.5secs to reach a soft landing this behaviour is aligned with how all the other async methods have been implemented
…eFailed() we just want to figure out exactly what kind of exception we get when the swap-timeout gets violated
…ementation now advertises the fatal-error-type enum too this allows for far more accurate error-detection - previously we had to resort to error-string sniffing which was a code-smell for example the image-swap-timeout error now gets accurately detected by the native java implementation of android the ios side will be refactored in a similar fashion in the upcoming commits
… native ios firmware-installer reports fatal errors so that it will include the error-type as well
…pe property of the event-args to detect the image-swap-timeout scenario
…tsFailedException_GivenRogueNativeErrorMessage): the test should now be working as intended
… the enum values explicit
…ssfully_GivenNoFilesToDownload, FileDownloaderTestbed.MultipleFilesDownloadAsync.ShouldCompleteSuccessfully_GivenNoFilesToDownload): raise the timeouts for these two test-cases
… to deal with phantom errors in the azure pipeline
…te' into ksidirop/MAN-209-create-test-suite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.