-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAN-209 create test suite #29
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptionally) a custom android-context
…will now be interpreted as 'wait forever' in the case that it is zero (old was: 0 would be honored as normal timeout)
…pecifying (optionally) a custom android-context
the eraser-proxy now supports an interface and a new internal constructor has been implemented which supports passing a custom proxy so as to facilitate mocking and testing
…ass unit-test friendly the implementations of ios and android have been realigned so that the native firmware-eraser implements the exact same interface for both world which in turn will allow us to mock it away in the exact same way for both platforms in our test suite this was deemed necessary to simplify the test suite altogether
…) and BeginErasure() to the shared part since they became identical in both iOS and Android over the last few commits
…reater granularity
…to ksidirop/MAN-209-create-test-suite
…y implementing the IFirmwareEraserEventEmitters interface so that these methods won't have to be public anymore
…s for the firmware eraser
…ests instead of vstest@3 which is only supported in windows
…few commits causing the build to always build the ios stuff even in non-osx platforms
…-framework-4.8 (old was: .net7 which was causing problems in macos)
…get 'Tests' and enrich the builder to invoke it
… to run tests since it was no longer needed
…ations of msbuild in the 'runtests' target to try and resolve a bug we observed in azure pipelines
…ipelines which was causing the packages of the test project to not be restored at all
…hem in a library exception
…s method on android
…ary commit to consolidate and simplify version handling
… csproj files to update the versions
…eFirmwareEraser()): raise the completion timeout to 1sec old was 150ms which was causing phantom timeouts in the azure pipeline
…_imageManager inside beginErasure()
the mocked up beginerasure() method now behaves properly in terms of launching its mocked up work in the background
…tion_GivenTooSmallTimeout()
…idn't use task.run on methods like BeginErase() [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.