[MAN-435] Fix error-mapping and exception-mapping on both iOS and Android #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ksidirop-laerdal
commented
Oct 29, 2024
- We no longer rely on string-sniffing
- The error-event-args and the exception now report the GlobalErrorCode
…red_() we now rely on the EMcuMgrErrorCode instead of relying on string-sniffing
…ception UploadErroredOutRemoteFolderNotFoundException() to not be thrown when the native Android code would report that target directory doesn't exist in the remote device
note that the file-uploader and file-downloader are broken with this commit on iOS and need to be fixed
…exception we now deduce a numeric global-error-code from it and send that to the C# world (old was: 2 separate and very confusing error codes)
…e global-error-code over to the C# side when an error occurs
…ow also report a global-error-code in case of a fatal-error
…to figure out the native errors instead of string-sniffing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.