[MAN-420] Fix build error concerning mac catalyst sdk version #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for the properties <TargetPlatformVersion> and <SupportedOSPlatformVersion> for all platforms when building through Laerdal.Builder.targets (which is used by github-actions.yml) these properties are set to the values of the env-vars defined at the top of github-actions.yml via the new msbuild parameters Laerdal_TargetPlatformVersion_IOS/Android/MacCatalyst
…nvoked with --disable-package-restore to avoid some issues with mac-catalyst builds when the mac-catalyst aspect of the build is disabled
…latformVersion> separately from the target sdk that was used to build each binding project For iOS and MacCatalyst we use TargetPlatformVersion=17.0 because this is what the macos-14 vm-image of our CI pipelines actually support (if we use values less than 17.0 we get a warning which says that in the future this will be considered an error)
…irop/MAN-420-fix-build-error-concerning-mac-catalyst-sdk-version # Conflicts: # .github/workflows/github-actions.yml # Laerdal.McuMgr.Bindings.MacCatalyst/Laerdal.McuMgr.Bindings.MacCatalyst.csproj # Laerdal.Scripts/Laerdal.Builder.targets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.