feat (Laerdal.McuMgr.Bindings.iOS/MacCatalyst.csproj): we now set NoB…

…indingEmbedding=true
Laerdal · May 24, 2024 · 0fd27f8 · 0fd27f8
1 parent 6c6ec45
commit 0fd27f8
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 23 deletions.
diff --git a/Laerdal.McuMgr.Bindings.MacCatalyst/Laerdal.McuMgr.Bindings.MacCatalyst.csproj b/Laerdal.McuMgr.Bindings.MacCatalyst/Laerdal.McuMgr.Bindings.MacCatalyst.csproj
@@ -24,23 +24,28 @@
 
         <TargetPlatformVersion>13.1</TargetPlatformVersion>
 
-        <DebugType>full</DebugType>
-        <Optimized>false</Optimized>
         <OutputPath>bin\</OutputPath>
         <OutputType>Library</OutputType>
         <LangVersion>10.0</LangVersion>
-        <DebugSymbols>true</DebugSymbols>
         <EnableDefaultCompileItems>false</EnableDefaultCompileItems>
 
-        <!-- see : https://github.com/xamarin/xamarin-macios/pull/12694 -->
-        <NoBindingEmbedding>false</NoBindingEmbedding>
-
         <NoWarn>$(NoWarn);CS0114;NETSDK1202</NoWarn>
 
         <NativeFrameworkParentFolderpath>$([System.IO.Path]::Combine($(MSBuildThisFileDirectory), 'Frameworks'))</NativeFrameworkParentFolderpath>
         <NativeFrameworkActualTargetFolderpath>$(NativeFrameworkParentFolderpath)/McuMgrBindingsiOS.framework</NativeFrameworkActualTargetFolderpath>
     </PropertyGroup>
 
+    <PropertyGroup>
+        <DebugType>full</DebugType>
+        <Optimized>false</Optimized>
+        <DebugSymbols>true</DebugSymbols>
+        <MtouchExtraArgs>-v -v -v -v</MtouchExtraArgs>
+        <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
+        <NoBindingEmbedding>true</NoBindingEmbedding>
+
+        <!-- 1. under net8 we need Optimized=false to be set otherwise release builds cause the resulting apps to crash right upon getting launched in the iphone! -->
+    </PropertyGroup>
+
     <PropertyGroup>
         <PackageId>Laerdal.McuMgr.Bindings.MacCatalyst</PackageId>
         <PackageTags>MAUI;Nordic;McuMgr;Bindings;Mac;MacCatalyst;</PackageTags>

diff --git a/Laerdal.McuMgr.Bindings.iOS/Laerdal.McuMgr.Bindings.iOS.csproj b/Laerdal.McuMgr.Bindings.iOS/Laerdal.McuMgr.Bindings.iOS.csproj
@@ -22,23 +22,31 @@
 
         <TargetPlatformVersion Condition=" '$(IsNetXIos)'   == 'true' ">11.0</TargetPlatformVersion>
 
-        <DebugType>full</DebugType>
-        <Optimized>false</Optimized>
         <OutputPath>bin\</OutputPath>
         <OutputType>Library</OutputType>
-        <LangVersion>10.0</LangVersion>
-        <DebugSymbols>true</DebugSymbols>
+        <LangVersion>10.0</LangVersion>        
+        <!-- setting IsBindingProject to true is vital in order for the btouch tools to actually -->
+        <!-- kick in and take the ApiDefinitions.cs and StructsAndEnums.cs files into account    -->
+        <IsBindingProject>true</IsBindingProject>
         <EnableDefaultCompileItems>false</EnableDefaultCompileItems>
 
-        <!-- see : https://github.com/xamarin/xamarin-macios/pull/12694    todo    test if we still need this in the dotnet8 era -->
-        <NoBindingEmbedding>false</NoBindingEmbedding>
-
         <NoWarn>$(NoWarn);CS0114;NETSDK1202</NoWarn>
 
         <NativeFrameworkParentFolderpath>$([System.IO.Path]::Combine($(MSBuildThisFileDirectory), 'Frameworks'))</NativeFrameworkParentFolderpath>
         <NativeFrameworkActualTargetFolderpath>$(NativeFrameworkParentFolderpath)/McuMgrBindingsiOS.framework</NativeFrameworkActualTargetFolderpath>
     </PropertyGroup>
 
+    <PropertyGroup>
+        <DebugType>full</DebugType>
+        <Optimized>false</Optimized>
+        <DebugSymbols>true</DebugSymbols>
+        <MtouchExtraArgs>-v -v -v -v</MtouchExtraArgs>
+        <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
+        <NoBindingEmbedding>true</NoBindingEmbedding>
+
+        <!-- 1. under net8 we need Optimized=false to be set otherwise release builds cause the resulting apps to crash right upon getting launched in the iphone! -->
+    </PropertyGroup>
+
     <PropertyGroup>
         <PackageId>Laerdal.McuMgr.Bindings.iOS</PackageId>
         <PackageTags>MAUI;Nordic;McuMgr;Bindings;iOS;Mac;</PackageTags>
@@ -97,16 +105,7 @@
         <None Remove="Laerdal.McuMgr.Bindings.iOS.csproj.DotSettings"/>
         <None Include="../Laerdal.McuMgr.Bindings.MacCatalystAndIos.Native/Laerdal.Mac.CompileAndGenerateFatLibs.sh"/>
     </ItemGroup>
-
-    <PropertyGroup>
-        <!-- setting IsBindingProject to true is vital in order for the btouch tools to actually -->
-        <!-- kick in and take the ApiDefinitions.cs and StructsAndEnums.cs files into account    -->
-        <IsBindingProject>true</IsBindingProject>
-
-        <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
-        <MtouchExtraArgs>-v -v -v -v</MtouchExtraArgs>
-    </PropertyGroup>
-
+
     <ItemGroup Condition=" '$(IsOSX)' == 'true' ">
         <!-- nothing to compile for the time being -->
         <!-- <Compile Include="iOS\*.cs"/> -->