More juicy speed-ups for wpt.fyi #3356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to filter by layer *once* instead of doing it for every rule that runs. Knocks ~2 seconds of loading time off of https://wpt.fyi/
Instead, change the APIs from "has :foo" to "may have :foo" and return true if we don't have a valid rule cache at the moment. This allows us to defer the rebuilding of the rule cache until a later time, for the cost of a wider invalidation at the moment. Do note that if our rule cache is invalid, the whole document has invalid style anyway! So this is actually always less work. :^) Knocks ~1 second of loading time off of https://wpt.fyi/
Instead of creating and passing around Vector<MatchingRule> inside StyleComputer (internally, not exposed in API), we now use vectors of pointers/references instead. Note that we use pointers in case we want to quick_sort() the vectors. Knocks 4 seconds of loading time off of https://wpt.fyi/
Knocks 1.1 seconds of loading time off of https://wpt.fyi/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's do a lot less work in StyleComputer on the WPT dashboard at https://wpt.fyi/
See individual commits.
Bonus: Remove some unnecessary copying in the AK::JsonValue constructors that was costing us a ton of time.