LibJS: Only run queued promise jobs if there is no embedder #3231
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shannonbooth
commented
Jan 12, 2025
| if (auto* custom_data = vm.custom_data()) { | ||
| // Embedder case (i.e. LibWeb). | ||
| custom_data->spin_event_loop_until(GC::create_function(vm.heap(), [success] { |
There was a problem hiding this comment.
spinning the event loop like this technically also runs all promise jobs, but I'm not 100% sure if the spin itself is fully correct for all cases and interleaving other potential stuff to happen.
There was a problem hiding this comment.
The running of queued promise jobs in non-embedder case below is definitely less correct than spinning the event loop in the sense it doesn't do the clear of the execution context stack, but I haven't quite figured out the normative impact of that yet
e853020 to
a8ffb78
Compare
This has no functional difference as run_queued_promise jobs does nothing when LibWeb is used as it has a different implementation of enqueuing and running promise jobs. But this change makes it more obvious that run_queued_promise jobs does nothing when there is an embedder, and adjusts the comment to reflect what the code is actually achieving.
a8ffb78 to
a043ba8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has no functional difference as run_queued_promise jobs does nothing when LibWeb is used as it has a different implementation of enqueuing and running promise jobs. But this change makes it more obvious that run_queued_promise jobs does nothing when there is an embedder, and adjusts the comment to reflect what the code is actually achieving.