LibWeb: Implement most of the Editing API commands #3216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it more consistent with the other signatures.
Commit 98df4c2 changes the node argument to a GC::Ref<DOM::Node>, but not all usages were updated accordingly.
The spec calls it a "node list", not "nodes".
This centralizes the logic for iterating over a Range's contained nodes.
Allows for easy iteration over the chain of ancestors for a node.
This prevents some unnecessary casting to DOM::Element.
If we are to insert nodes _before_ the original parent, we need to insert them at the original parent's index, not the index before that.
This makes some of the spec implementations easier to follow and makes it extra clear that the range is optional.
The associated spec was only partially implemented.
Minus the autolinking algorithm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost all commands in the spec are implemented, save for undo/redo and the clipboard commands.
Results in ~16.5k additional WPT passes.
Some of the functionalities can be tested here, although the modal input dialogs crash for some reason:
https://codepen.io/chrisdavidmills/full/gzYjag/