Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibWeb: Check for missing node or invalid query in obtain_theme_color #3207

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

LibWeb: Check for missing node or invalid query in obtain_theme_color #3207

wants to merge 2 commits into from
+12 −3

Conversation

Gingeh
Copy link
Contributor

@Gingeh Gingeh commented Jan 10, 2025

Fixes #3205.

@Gingeh Gingeh force-pushed the theme-color-null-node branch from bcc9ea5 to 4c2e907 Compare January 10, 2025 09:37
tcl3
tcl3 reviewed Jan 10, 2025
View reviewed changes
Copy link
Member

@tcl3 tcl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some kind of minimal in-tree test you could add for this? I can't reproduce the original crash.

Libraries/LibWeb/DOM/Document.cpp Outdated Show resolved Hide resolved
@Gingeh Gingeh force-pushed the theme-color-null-node branch from 4c2e907 to 9b95c3d Compare January 10, 2025 22:58
@Gingeh
Copy link
Contributor Author

Gingeh commented Jan 10, 2025

Is there some kind of minimal in-tree test you could add for this? I can't reproduce the original crash.

Done, note that the crash only occurs in debug builds because it's hitting an ASSERT(m_ptr)

@shannonbooth
Copy link
Contributor

Is there some kind of minimal in-tree test you could add for this? I can't reproduce the original crash.

Done, note that the crash only occurs in debug builds because it's hitting an ASSERT(m_ptr)

Oh right, yeah I only ever compile with debug, I find the assertion in GC::Ptr too useful to not have it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcl3 tcl3 tcl3 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ladybird crashes on https://github.com
3 participants
@Gingeh @shannonbooth @tcl3