Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb: Split the qualified name if there is a prefix #2467

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

ananas-dev
Copy link
Contributor

This fixes (at least) one WPT test and I imported it :)

The expected behavior is described here in the spec:
https://dom.spec.whatwg.org/#concept-element-local-name

It was already implemented correctly when constructing a QualifiedName in Element::validate_and_extract.

I don't know if my sequence of string conversions is the most efficient though, but don't hesitate to comment if there is a better one so that I can learn my way around AK.

@ladybird-bot
Copy link
Collaborator

Hello!

One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the lint_commits CI job for more details on which commits were flagged and why.
Please do not close this PR and open another, instead modify your commit message(s) with git commit --amend and force push those changes to update this PR.

@ananas-dev ananas-dev force-pushed the firstelementchild-namespace branch from 9dcc954 to 0ce6cd6 Compare November 20, 2024 22:37
Copy link
Member

@tcl3 tcl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Sorry it's taken a while to get to. There is currently a conflict that needs to be resolved.

@ananas-dev ananas-dev force-pushed the firstelementchild-namespace branch from 0ce6cd6 to e3347c5 Compare December 6, 2024 01:05
@ananas-dev ananas-dev force-pushed the firstelementchild-namespace branch from 0e2b9de to 941c40b Compare December 6, 2024 01:15
@ananas-dev
Copy link
Contributor Author

Thanks for working on this! Sorry it's taken a while to get to. There is currently a conflict that needs to be resolved.

Thanks for the review :)
I changed the code to use DOM::validate_and_extract and added the error handling you suggested. I also added the same error handling to the DOM::create_element call right below since I figured I would make sense.

Copy link
Member

@tcl3 tcl3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please use the "Resolve conversation" button when you've dealt with review feedback.

@tcl3 tcl3 merged commit 3c2bbd4 into LadybirdBrowser:master Dec 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants