-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LibWeb: Split the qualified name if there is a prefix #2467
LibWeb: Split the qualified name if there is a prefix #2467
Conversation
Hello! One or more of the commit messages in this PR do not match the Ladybird code submission policy, please check the |
9dcc954
to
0ce6cd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! Sorry it's taken a while to get to. There is currently a conflict that needs to be resolved.
Tests/LibWeb/Text/expected/wpt-import/dom/nodes/Element-firstElementChild-namespace-xhtml.txt
Outdated
Show resolved
Hide resolved
0ce6cd6
to
e3347c5
Compare
0e2b9de
to
941c40b
Compare
Thanks for the review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Please use the "Resolve conversation" button when you've dealt with review feedback.
This fixes (at least) one WPT test and I imported it :)
The expected behavior is described here in the spec:
https://dom.spec.whatwg.org/#concept-element-local-name
It was already implemented correctly when constructing a
QualifiedName
inElement::validate_and_extract
.I don't know if my sequence of string conversions is the most efficient though, but don't hesitate to comment if there is a better one so that I can learn my way around AK.