Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb: Plumbing for svg stroke-dashoffset #2435

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

nico
Copy link
Contributor

@nico nico commented Nov 19, 2024

Similar to stroke-width:

https://svgwg.org/svg2-draft/painting.html#StrokeWidth
https://svgwg.org/svg2-draft/painting.html#StrokeDashing (scroll down a bit)

(stroke-dasharray will need custom parsing as far as I can tell.)

@nico nico requested a review from AtkinsSJ as a code owner November 19, 2024 02:23
@@ -266,13 +267,10 @@ Optional<float> SVGGraphicsElement::stroke_opacity() const
return layout_node()->computed_values().stroke_opacity();
}

Optional<float> SVGGraphicsElement::stroke_width() const
Optional<float> SVGGraphicsElement::resolve_relative_to_viewport_size(CSS::LengthPercentage const& length_percentage) const
Copy link
Contributor Author

@nico nico Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I made the body of what previously was stroke_width() a new helper that's called by both stroke_dashoffset and stroke_width).)

@nico nico force-pushed the svg-stroke-dashoffset branch 4 times, most recently from fd347e7 to 66f4ed9 Compare November 19, 2024 13:16
@nico
Copy link
Contributor Author

nico commented Nov 19, 2024

Red CI is (now) due to an unrelated PR, see #2422 (comment)

@nico nico force-pushed the svg-stroke-dashoffset branch from 66f4ed9 to d4ce3cd Compare November 19, 2024 16:44
@nico nico force-pushed the svg-stroke-dashoffset branch from d4ce3cd to d621dcd Compare November 19, 2024 20:17
@gmta gmta merged commit 6fc06f4 into LadybirdBrowser:master Nov 20, 2024
6 checks passed
@nico nico deleted the svg-stroke-dashoffset branch November 20, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants