Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document #25, #27. Work around #26. Fix #29, #30. #28

Merged
17 commits merged into from
Jun 21, 2022
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jun 15, 2022

Ran into some bugs while working on a library which calls Starwatch's API.

#26 seems fixed so far in testing just by try/catching, but I don't know the full reason why the issues were happening.

I'm not sure if you have any insight on these problems, but the following routes are having issues (which we haven't ran into since they're not commonly used):

Unstable

  • AccountDetailsRoute - DEL route can cause connection to close unexpectedly

Unusable

  • AccountAuthorizationRoute - Fails to convert :account to an Account object
  • AccountProtectionRoute - :account fails to be replaced in MySQL, and causes syntax error

@ghost ghost added the bug Something isn't working label Jun 15, 2022
@ghost ghost requested a review from Lachee June 15, 2022 22:16
@ghost ghost changed the title Document #25, #27 and Work around #26 Document #25, #27. Work around #26. Fix #29, #30. Jun 17, 2022
@ghost ghost merged commit 3cb59de into master Jun 21, 2022
@ghost ghost deleted the mini/minor-bugfixes branch June 21, 2022 22:54
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
0 participants