Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for groups grid to load on permissions page #2240

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

labkey-tchad
Copy link
Member

Rationale

If a test doesn't wait for the groups grid to load, it can cause a JavaScript error by creating a group too quickly.

TypeError: this.user is null
  initComponent (http://localhost:8111/Security/window/UserInfoPopup.js:20:43)
  [...]
  showPopup (http://localhost:8111/Security/panel/PermissionEditor.js:230:26)
  success (http://localhost:8111/Security/util/SecurityCache.js:349:30)
  responseTransformer.call (webpack://@labkey/api/src/labkey/Utils.ts:484:15)
  callback (webpack://@labkey/api/src/labkey/Ajax.ts:130:11)
  onreadystatechange (webpack://@labkey/api/src/labkey/Ajax.ts:322:12)

Related Pull Requests

  • N/A

Changes

  • Wait for grid to load on "Site Groups" page
  • Wait for grid to load on "Project Groups" page
  • Add some logging to help track down usages of deprecated enterAdminMode

@labkey-tchad labkey-tchad changed the title Wait for grid to load on "Site Groups" page Wait for groups grid to load permissions page Jan 24, 2025
@labkey-tchad labkey-tchad merged commit a3ca1fb into develop Jan 24, 2025
2 checks passed
@labkey-tchad labkey-tchad deleted the fb_siteGroupTiming branch January 24, 2025 20:06
@labkey-tchad labkey-tchad changed the title Wait for groups grid to load permissions page Wait for groups grid to load on permissions page Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants