Handle MultipleFailureException thrown by tests #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Problematic tests are now collecting screenshots: https://teamcity.labkey.org/buildConfiguration/bt310/3351706 |
labkey-danield
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Sometimes test use
@Afteror@AfterClassannotations against our recommendation. If a test fails and the after method also throws an exception, JUnit combines the errors into aMultipleFailureException. This can mask the actual error, makingBaseWebDriverTest.handleFailureunable to perform its duties (e.g. close alerts). We mostly care about the primary test failure so we can just pull that out of theMultipleFailureException.Related Pull Requests
Changes
MultipleFailureExceptionthrown by tests