component updates for auto-hit-selection #2218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-tchad
requested changes
Jan 6, 2025
| { | ||
| throw new IllegalStateException("Apply button is not enabled."); | ||
| } | ||
| elementCache().submitButton.click(); |
There was a problem hiding this comment.
Wait for dialog to close.
Suggested change
| elementCache().submitButton.click(); | |
| elementCache().submitButton.click(); | |
| waitForClose(); |
If possible, add some synchronization that waits for the DomainFieldRow to update.
labkey-tchad
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
This adds component support needed for automatic hit-selection test coverage in Biologics.
Related Pull Requests
https://github.com/LabKey/limsModules/pull/1043
Changes
Add hit selection summary and button controls to
DomainFieldRowAdd hit selection summary and button control to
ReactAssayDesignerPagenew Dialog,
HitSelectionDialog