Wait for readyState when switching test windows #2191
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
A change to how we switch windows was accidentally included in a previous PR. It attempts to prevent errors with
assertTextPresent
throwing an NPE after switching windows by waiting fordocument.readyState
to be"complete"
. This mostly works, except one place in WNPRC that opens a window in a unique method. In Firefox, thereadyState
of that page is the nonstandard "uninitialized".Note: the test timeout was caused by using seconds instead of milliseconds for the readyState timeout. That has also been fixed.
Related Pull Requests
Changes
Duration.ofMillis
instead ofDuration.ofSeconds
for timeout