Missing property descriptor for attribute exception handling #184
Conversation
…ot found for an attribute.
…he propertyDescriptor is found even if the attribute name does not match value in the property descriptor name.
| propertyDescriptor = OntologyManager.getPropertyDescriptor(attributeData.getPropertyId()); | ||
| propertyDescriptor = OntologyManager.getPropertyDescriptor(PackageDomainKind.getDomainURI( | ||
| SNDSchema.NAME, PackageDomainKind.getPackageKindName(), c, u) + "-" + pkgId + "#" + | ||
| attributeData.getPropertyName().replaceAll("\\s", "+"), c); |
There was a problem hiding this comment.
PageFlowUtil.encode(attributeData.getPropertyName())
Might need to do a quick test on this, but this should handle how these names are expected to be encoded.
There was a problem hiding this comment.
Hi Marty,
Thanks for looking at the PR. Unfortunately, your suggestion is not going to work. The PageFlowUtil.encode() method replaces the space with a %20, resulting in, for example, body%20part. In the attribute data, the propertyURI replaces the space with a +. Here is the propertyURI for the body part attribute:
urn:lsid:txbiomed.org:package-snd.Folder-6:Package-62#body+part
Both the + and the %20 are proper URL encodings for the space, but the OntologyManager.getPropertyDescriptor() function is doing a key/value lookup in the property descriptor cache, with the propertyURI as the key, and it is failing when the encoding doesn’t match.
There was a problem hiding this comment.
Sorry I didn't do enough investigation into that. Here is the function that is being used when those are first encoded. Let me know if that works for you.
Lsid.encodePart(attributeData.getPropertyName())
There was a problem hiding this comment.
That does the trick! I'll submit a new PR for the change. Thanks!
Rationale
We need to roll back the SaveEvent transaction when an SND attribute cannot be updated because the PD has an invalid name.
MDP-88: SNPRC_Mobile - Fix SND saveEvent API failure to report error when propertyDescriptor is not found for AttributeData