Add support for comments during edit actions #5286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 1, 2024
Merged
Adjust
updateRow and importData interfaces to account for auditUserComments
LabKey/customModules#167
Merged
Merged
cnathe
approved these changes
Mar 4, 2024
…ss through user comment to more audit events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
We have previously added the ability for users to provide comments on various types of data changes (deleting, moving, discarding, etc.). With this PR and its relatives we introduce the ability to provide comments for edits of data in various forms, including editing in bulk or in the grid, updating via a file, reimporting and assay run, and editing on a details page.
Related Pull Requests
Changes
updateRowsto include theconfigParametersmap, which contains, among other things, any comment provided by the user that should be added to audit logsimportDatainterface to includeauditUserCommentauditUserCommentwhen creating audit events fromAbstractQueryUpdateServiceAssayRunUploadContextandcreateDataIteratorContextwith newauditUserCommentfieldImportRunApiActionto account forauditUserComment