Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing problematic section of pyproject.toml, tool.setuptools.packages.find #43

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

drewoldag
Copy link
Collaborator

@drewoldag drewoldag commented Oct 26, 2023

This section of the pyproject.toml file seems to cause a lot of issues and doesn't appear to be required to define a package as being a namespace package. It seems like python just figures it out without this specification.

@drewoldag drewoldag requested a review from eacharles October 26, 2023 22:35
@drewoldag drewoldag self-assigned this Oct 26, 2023
@drewoldag drewoldag linked an issue Oct 26, 2023 that may be closed by this pull request
@drewoldag drewoldag enabled auto-merge (squash) October 26, 2023 22:37
Copy link

@eacharles eacharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Drew

@drewoldag drewoldag merged commit e908d14 into main Oct 26, 2023
@drewoldag drewoldag deleted the issue/42/remove-setuptools-packages-find branch October 26, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove tool.setuptools.packages.find section of pyproject.toml
2 participants