initial draft of trimmed template #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eacharles
approved these changes
Aug 3, 2023
further trimming
|
@eacharles Yeah, I have to agree. I trimmed out the explanatory text and consolidated the checkboxes further. What do you think? |
OliviaLynn
approved these changes
Aug 4, 2023
sschmidt23
approved these changes
Aug 4, 2023
There was a problem hiding this comment.
it's a little odd that three of the four have a "positive" check box (i.e. checked = good), while the last one about including a breaking change is unchecked = good. Maybe rephrase the last one to be "I do not include any breaking changes" as the default, and thus seeing the box unchecked would stand out more?
Not a big deal, but I did notice it. I'll approve, change the above if you feel like it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address #26, I took out most of the checkboxes, leaving just the ones that are most relevant to the RAIL team's workflow.