Safari would not handle frame accesses when using the legacy(?) `fram…

…es` object, instead of `document`. Signed-off-by: Michael Herger <michael@herger.net>
LMS-Community · Feb 8, 2025 · 55c145f · 55c145f
1 parent ec548d4
commit 55c145f
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 9 deletions.
diff --git a/HTML/Default/html/Main.js b/HTML/Default/html/Main.js
@@ -202,8 +202,9 @@ Main = {
 			playerobj = SqueezeJS.getPlayer();
 
 		// set the browser frame to use the selected player
-		if (frames.browser && frames.browser.location && frames.browser.location.protocol.match(/^http/)) {
-			frames.browser.location = SqueezeJS.Utils.replacePlayerIDinUrl(frames.browser.location, playerobj);
+		const location = frames.browser && frames.browser.location || document.browser.location;
+		if (location.protocol.match(/^http/)) {
+			SqueezeJS.Utils.setBrowseLocation(SqueezeJS.Utils.replacePlayerIDinUrl(location, playerobj));
 		}
 
 		// make the settings link use the new player ID
@@ -424,8 +425,8 @@ Main = {
 					tooltip:  SqueezeJS.string('save'),
 					minWidth: 32,
 					noText:   true,
-					handler:  function(){
-						frames.browser.location = webroot + 'edit_playlist.html?player=' + SqueezeJS.Controller.getPlayer() + '&saveCurrentPlaylist=1';
+					handler:  function() {
+						SqueezeJS.Utils.setBrowseLocation(webroot + 'edit_playlist.html?player=' + SqueezeJS.Controller.getPlayer() + '&saveCurrentPlaylist=1');
 					}
 				});
 

diff --git a/HTML/Default/index.html b/HTML/Default/index.html
@@ -99,10 +99,7 @@
 					}
 				}
 
-				if (frames.browser.location)
-					frames.browser.location.href = navigationUrl;
-				else if (document.browser.location)
-					document.browser.location.href = navigationUrl;
+				SqueezeJS.Utils.setBrowseLocation(navigationUrl);
 
 				if (Ext.ux.Lightbox) {
 					Ext.ux.Lightbox.labelOf = '[% "OF" | string %]';

diff --git a/HTML/EN/html/SqueezeJS/Base.js b/HTML/EN/html/SqueezeJS/Base.js
@@ -810,7 +810,7 @@ SqueezeJS.SonginfoParser = {
 
 SqueezeJS.Utils = {
 	replacePlayerIDinUrl : function(url, id){
-		if (!id)
+		if (!id || !url)
 			return url;
 
 		if (typeof url == 'object' && url.search != null) {
@@ -898,6 +898,13 @@ SqueezeJS.Utils = {
 		});
 
 		return parts;
+	},
+
+	setBrowseLocation: function(url) {
+		if (frames.browser.location)
+			frames.browser.location.href = url;
+		else if (document.browser.location)
+			document.browser.location.replace(url);
 	}
 };