-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support building with MSVC #19
Conversation
👍 Many parts of this PR might not be applied to current zyn's master (e.g. some variables do not occur there, and we meanwhile also have the |
This is something I definitely plan to do eventually, especially since we plan on updating our Zyn version and presumably still want to be able to build everything with MSVC. Right now, this is mostly for personal convenience as I'm working on our remote plugin IPC interface and want to be able to test my changes with Zyn more easily. |
In a second look, I noticed that |
Oh, We already do that for |
Yeah, it's not ideal, but I needed it in the LMMS repository too, and didn't want to duplicate it. As you say, we already do the same for |
See also LMMS/lmms#6561.
This pull request mostly consists of routine transformations from POSIX APIs to the C++ standard library, along with
_alloca
alternatives for variable-length stack arrays. In order to keep things easy to review, and maybe pull in other upstream changes, I haven't tried to improve the code by using things such as RAII lock guards (except where required, i.e. in conjunction with a condition variable). As an exception, I took the opportunity to support Unicode paths in a few places by using wide character functions on Windows.