Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/detach-window] Transfer size restrictions to embedded widget from SubWindow #7596

Merged
merged 5 commits into from
Dec 3, 2024

Conversation

SpomJ
Copy link
Contributor

@SpomJ SpomJ commented Nov 23, 2024

This is the first part which mostly unifies how existing size restrictions are handled. It seems most other restrictions happen in plugins, I intend to do them a bit later.

@SpomJ SpomJ closed this Nov 23, 2024
@SpomJ SpomJ force-pushed the feature/detach-window branch from e3501e7 to adce178 Compare November 23, 2024 12:26
@SpomJ SpomJ reopened this Nov 23, 2024
@SpomJ SpomJ mentioned this pull request Nov 23, 2024
Copy link
Member

@messmerd messmerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions

src/gui/MixerView.cpp Outdated Show resolved Hide resolved
src/gui/MidiCCRackView.cpp Outdated Show resolved Hide resolved
src/gui/MicrotunerConfig.cpp Outdated Show resolved Hide resolved
src/gui/ControllerRackView.cpp Outdated Show resolved Hide resolved
src/gui/widgets/TempoSyncBarModelEditor.cpp Outdated Show resolved Hide resolved
src/gui/widgets/TempoSyncKnob.cpp Outdated Show resolved Hide resolved
@SpomJ
Copy link
Contributor Author

SpomJ commented Dec 3, 2024

Should be good now

@messmerd messmerd merged commit c85b498 into LMMS:feature/detach-window Dec 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants