Add MSVC support for GigPlayer (rework)

CMakeLists.txt

@@ -530,14 +530,14 @@ ENDIF(WANT_SF2)
 
 # check for libgig
 If(WANT_GIG)
-	PKG_CHECK_MODULES(GIG gig)
+	find_package(Gig)
 	IF(GIG_FOUND)
 		SET(LMMS_HAVE_GIG TRUE)
 		SET(STATUS_GIG "OK")
-	ELSE(GIG_FOUND)
+	ELSE()
 		SET(STATUS_GIG "not found, libgig needed for decoding .gig files")
-	ENDIF(GIG_FOUND)
-ENDIF(WANT_GIG)
+	ENDIF()
+ENDIF()
 
 # check for pthreads
 IF(LMMS_BUILD_LINUX OR LMMS_BUILD_APPLE OR LMMS_BUILD_OPENBSD OR LMMS_BUILD_FREEBSD OR LMMS_BUILD_HAIKU)

cmake/modules/FindGig.cmake

@@ -0,0 +1,32 @@
+# Copyright (c) 2024 Kevin Zander
+# Based on FindPortAudio.cmake, copyright (c) 2023 Dominic Clark
+#
+# Redistribution and use is allowed according to the terms of the New BSD license.
+# For details see the accompanying COPYING-CMAKE-SCRIPTS file.
+
+include(ImportedTargetHelpers)
+
+find_package_config_mode_with_fallback(gig libgig::libgig
+	LIBRARY_NAMES "gig"
+	INCLUDE_NAMES "libgig/gig.h"
+	PKG_CONFIG gig
+	PREFIX Gig
+)
+
+determine_version_from_source(Gig_VERSION libgig::libgig [[
+	#include <iostream>
+	#include <libgig/gig.h>
+
+	auto main() -> int
+	{
+		const auto version = gig::libraryVersion();
+		std::cout << version;
+	}
+]])
+
+include(FindPackageHandleStandardArgs)
+
+find_package_handle_standard_args(Gig
+	REQUIRED_VARS Gig_LIBRARY Gig_INCLUDE_DIRS
+	VERSION_VAR Gig_VERSION
+)

plugins/GigPlayer/CMakeLists.txt

@@ -3,15 +3,34 @@ if(LMMS_HAVE_GIG)
 	include_directories(SYSTEM ${GIG_INCLUDE_DIRS})
 	SET(CMAKE_AUTOUIC ON)
 
+	# Version checking logic disabled for msvc as vcpkg guarantees gig > 4.3
+	if(NOT MSVC)
+		string(REPLACE "." ";" GIG_VERSION_LIST "${Gig_VERSION}")
+		list(LENGTH GIG_VERSION_LIST GIG_VERSION_LIST_LENGTH)
+		list(GET GIG_VERSION_LIST 0 GIG_VERSION_MAJOR)
+		list(GET GIG_VERSION_LIST 1 GIG_VERSION_MINOR)
+		list(GET GIG_VERSION_LIST 2 GIG_VERSION_PATCH)
+		if(GIG_VERSION_LIST_LENGTH GREATER 3)
+			list(GET GIG_VERSION_LIST 3 GIG_VERSION_REVISION)
+		endif()
+		configure_file("lmms_gig.h.in" "${CMAKE_BINARY_DIR}/lmms_gig.h")
+	endif()
+
+	# FIXME: Make sure we build globally with exceptions enabled and we can remove this
 	# Required for not crashing loading files with libgig
 	add_compile_options("-fexceptions")
 
+	# disable deprecated check for mingw-x-libgig
+	if(LMMS_BUILD_WIN32 AND NOT MSVC)
+		add_compile_options("-Wno-deprecated")
+	endif()
+
 	link_directories(${GIG_LIBRARY_DIRS})
 	link_libraries(${GIG_LIBRARIES})
 	build_plugin(gigplayer
 		GigPlayer.cpp GigPlayer.h PatchesDialog.cpp PatchesDialog.h PatchesDialog.ui
 		MOCFILES GigPlayer.h PatchesDialog.h
 		EMBEDDED_RESOURCES "${CMAKE_CURRENT_SOURCE_DIR}/*.png"
 	)
-	target_link_libraries(gigplayer SampleRate::samplerate)
+	target_link_libraries(gigplayer SampleRate::samplerate libgig::libgig)
 endif(LMMS_HAVE_GIG)