Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set SF2 voice tuning relative to initial value #6924

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

DomClark
Copy link
Member

@DomClark DomClark commented Oct 6, 2023

Fixes #6922 and fixes #6915. SoundFonts can specify an initial value for the coarse detuning of a voice, which we should take into account when applying our own detuning.

Copy link
Member

@messmerd messmerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it but it looks simple enough

Copy link
Contributor

@sakertooth sakertooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DomClark DomClark merged commit 21dc88c into LMMS:master Oct 10, 2023
@DomClark DomClark deleted the sf2-fix-voice-tuning branch October 10, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some SF2 patches play inconsistently Soundfont player: Some soundfonts pitch is incorrect
3 participants