-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use deprecated Qt5 functions #5086
Conversation
Bring master up to date
bring master up to date
This PR builds fine on my machine (Arch Linux, x86-64). However, it fails with a compilation error on travis and circleci... |
The change was introduced in Qt 5.11, but the latest Qt version that's officially supported is 5.9. I think you should either revert the change or use |
The |
I think it can be replaced with functor-based connections. In other words, you can connect signals to lambda functions in Qt5. See https://doc.qt.io/qt-5/qobject.html#connect-4 and https://doc.qt.io/qt-5/qobject.html#connect-5 for details. |
OK, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is good, except unrelated whitespace changes. If your editor keeps doing it, I can manually do them before merging.
Sorry about that, my editor was misconfigured and I didnt notice until after commit+push. Shouldnt happen again. |
I found that |
Superseded by #5156. |
This PR removes a number of deprecated QT functions.
QColor::dark()
becomesQColor::darker()
QColor::light()
becomesQColor::lighter()
QFontMetrics::width()
becomesQFontMetrics::horizontalAdvance()
QDir
objects can no longer have their paths set viaoperator=
, useQDir::setPath()
insteadI still get compiler warnings about obsolete
QSignalMapper
but I don't know enough Qt to remove them.