Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Envelope time #411

Merged
merged 2 commits into from
Mar 5, 2014
Merged

Envelope time #411

merged 2 commits into from
Mar 5, 2014

Conversation

zonkmachine
Copy link
Member

First commit for issue #207

Here is a working example. The gui will extend out of the frame if you max out many of the values. I think it's better to let it disappear under the frame if you do this. The only time this would happen is basically if you deliberately set out to see what happens when you set all the values to their maximum.

@diizy
Copy link
Contributor

diizy commented Mar 5, 2014

On 03/05/2014 04:45 AM, Oskar Wallgren wrote:

First commit for issue #207 #207

Here is a working example. The gui will extend out of the frame if you
max out many of the values. I think it's better to let it disappear
under the frame if you do this. The only time this would happen is
basically if you deliberately set out to see what happens when you set
all the values to their maximum.


Or we could add in some GUI code to adjust the coordinates by a factor,
if the total length of the envelope goes above a treshold.

Something like:

each graph x coordinate = x * x_factor

if total_length < treshold, x_factor = 1 // show envelope normally like
before
if total_length > treshold, x_factor = treshold / total length

@diizy
Copy link
Contributor

diizy commented Mar 5, 2014

Another option would be to move the AMT knob to the right side of REL and make the envelop graph frame wider.

Although, the cases where the current frame isn't sufficient are probably so marginal, that it'd probably be entirely fine to just make it so that the graph gets clipped to the bounds of the frame.

tobydox added a commit that referenced this pull request Mar 5, 2014
@tobydox tobydox merged commit 10b1f12 into LMMS:stable-0.4 Mar 5, 2014
@zonkmachine zonkmachine deleted the Envelope_time branch March 5, 2014 15:54
@zonkmachine
Copy link
Member Author

Or we could add in some GUI code to adjust the coordinates by a factor, if the total length of the envelope goes above a treshold.

That's tempting but I think the "Just cut the end off" method works better for me.

Another option would be to move the AMT knob to the right side of REL and make the envelop graph frame wider.

That would mean lost space for possible future modifications. The fixed tiny format of the GUI is bit of a challenge really.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants