Update Pattern.cpp #3325
Closed
Update Pattern.cpp #3325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So BB Editor changes with time signature.
Add and Subtract notes
|
I hate git... Realized after I posted the code, it needs to update the length of the pattern to fit on the main pattern page. I like the way it looks, but I'll need to dig into the code some more to see how that's done. |
If you sync your branch up exactly with master and push, it auto-closes the PRs. No worries, just open a new one when ready. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So BB Editor changes with time signature.
If you select 2/2 time, you get 2/2 time in your BB Editor.
If you select 3/4 time, then that's what you get.
Doesn't change the Add More button, or anything like that.
It still doubles 'em so that should be fine.
Goes along with 2636