improve mouse pointer in piano roll editor #3065

BaraMGB · 2016-10-06T14:05:43Z

I can't make screenshots with mouse pointer.

This PR change the following things:

the mouse pointer changes its appearance proper on all borders of the key area
we use a pencil ( or eraser ) instead of the arrow with pencil icon
the rubberband icon don't stuck anymore on a border when the mouse pointer leaves the area

Umcaruje

Generally there is a lot of random identation changes all over the PR that make it hard to review. Please fix this.

Umcaruje · 2016-10-07T19:53:02Z

src/gui/editors/PianoRoll.cpp

@@ -216,7 +218,7 @@ PianoRoll::PianoRoll() :
 		m_noteEditMenu->addAction( act );
 	}
 	connect( signalMapper, SIGNAL(mapped(int)),
-			this, SLOT(changeNoteEditMode(int)) );
+			 this, SLOT(changeNoteEditMode(int)) );


Why is a space added here

Umcaruje · 2016-10-07T19:53:30Z

src/gui/editors/PianoRoll.cpp

@@ -261,32 +263,32 @@ PianoRoll::PianoRoll() :
 	if( s_whiteKeySmallPm == NULL )
 	{
 		s_whiteKeySmallPm = new QPixmap( embed::getIconPixmap(
-						"pr_white_key_small" ) );
+											 "pr_white_key_small" ) );


Why are all these lines more indented

Umcaruje · 2016-10-07T19:53:47Z

src/gui/editors/PianoRoll.cpp

-						Song::Mode_PlayPattern ),
-						m_currentPosition, this );
+									 Engine::getSong()->getPlayPos(
+										 Song::Mode_PlayPattern ),


Umcaruje · 2016-10-07T19:56:14Z

I'll now go and test this out

Umcaruje · 2016-10-07T20:02:52Z

This works nice, and feels a lot more natural. However, the automation editor is now inconsistent with this, so I guess the same thing should be done there. Other than the indentation issues, this looks ok to me.

BaraMGB · 2016-10-07T20:14:19Z

Fine, I'll fix it. Perhaps this should be tested on Apple and Windows, too.

Umcaruje · 2016-10-08T10:09:21Z

src/gui/editors/PianoRoll.cpp

 		repaint();
 		return;
 	}
-
+	


unnecessary white space here

BaraMGB · 2016-10-08T23:29:30Z

@tresf can you test this on mac, please?

tresf · 2016-10-09T14:09:12Z

I can't make screenshots with mouse pointer.

You can with a cellphone or a virtual machine.

@tresf can you test this on mac, please?

I don't see any OS-specific code, so I'm not sure why this is needed. I have MacOS Qt4 and Qt5 builds here: https://github.com/tresf/lmms/releases/tag/v1.2.0-RC2-MOUSE

Test results Qt5 10.8 Homebrew build running on 10.11:

the mouse pointer changes its appearance proper on all borders of the key area
- Yes, the piano keys seem to be ok on hover although the cursor lingers after hovering over a note.
we use a pencil ( or eraser ) instead of the arrow with pencil icon
- No, the 4-directional arrow is what's displayed on Mac.
the rubberband icon don't stuck anymore on a border when the mouse pointer leaves the area
- This seems to be true although the cursor/marker area seems to still have the lasso, I'd assume it would disappear there, not the toolbar.

BaraMGB · 2016-10-09T18:37:34Z

I don't see any OS-specific code, so I'm not sure why this is needed.

Because the behavior is completely different from what I see on Linux. :(

liushuyu · 2016-11-08T20:39:04Z

So is this cooled down or still working in progress? I think this fix is somewhat important

BaraMGB · 2016-11-08T23:38:57Z

I need A video of what's happening in macOS. @simonvanderveldt?

BaraMGB · 2017-01-27T14:26:22Z

I would like to merge this into master, but I can not test if this works on MacOS. Can someone test this?

tresf · 2017-01-27T14:51:54Z

I would like to merge this into master, but I can not test if this works on MacOS. Can someone test this?

Test what? I don't see any new commits since my testing on 2016-10-09

zonkmachine · 2017-01-28T16:32:26Z

This works well over here.

No, the 4-directional arrow is what's displayed on Mac.

I had a peek at the qt bug tracker but nothing popped up as an absolute fit for this case. Though there were other reports of wrong cursors displayed.

@BaraMGB If this needs more testing you might wanna squash and rebase it.

BaraMGB · 2017-02-08T10:18:28Z

although the cursor lingers after hovering over a note.

@tresf can you test please if the Qt::SizeAllCursor is shown anymore and if it's stuck on leaving the note?

zonkmachine · 2017-02-08T13:49:35Z

I just noticed the cursor is a bit nervous around the border to the NoteEditArea. It's a bit difficult to hit the spot where you resize and when you're doing the ActionResizeNoteEditArea the cursor is flickering.

tresf · 2017-02-09T04:31:23Z

can you test please if the Qt::SizeAllCursor is shown anymore and if it's stuck on leaving the note?

Just re-tested on fresh BaraMGB/pianorollmousepointer branch and it's still stuck on Mac. Results are identical to the animated GIFs from #3065 (comment).

BaraMGB · 2017-06-01T12:37:26Z

I'll close this out. At the moment I have no chance to debug it on a mac. Perhaps I'll find a way in the future.

zonkmachine · 2017-10-31T11:38:45Z

Maybe a hint in #3926

BaraMGB added 2 commits October 3, 2016 13:00

sets mousepointer in piano roll editor

f3677db

improve the mouse pointer in piano roll

b2c581d

Umcaruje requested changes Oct 7, 2016

View reviewed changes

BaraMGB added 2 commits October 8, 2016 10:41

Whitespaces

6738ca2

Whitespaces 2

faa4801

Umcaruje approved these changes Oct 8, 2016

View reviewed changes

Umcaruje reviewed Oct 8, 2016

View reviewed changes

src/gui/editors/PianoRoll.cpp Outdated

repaint();

return;

}

Copy link

Member

Umcaruje Oct 8, 2016 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary white space here

Whitespace 3

7820880

BaraMGB mentioned this pull request Jan 27, 2017

Piano Roll - Vertical arrow cursor stuck #3306

Closed

Qt::SizeAllCursor deactivated on mouse over note

8928d4a

BaraMGB closed this Jun 1, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

improve mouse pointer in piano roll editor #3065

improve mouse pointer in piano roll editor #3065

BaraMGB commented Oct 6, 2016

Umcaruje left a comment

Umcaruje Oct 7, 2016

Umcaruje Oct 7, 2016

Umcaruje Oct 7, 2016

Umcaruje commented Oct 7, 2016

Umcaruje commented Oct 7, 2016

BaraMGB commented Oct 7, 2016

Umcaruje Oct 8, 2016 •

edited

Loading

BaraMGB commented Oct 8, 2016

tresf commented Oct 9, 2016 •

edited

Loading

BaraMGB commented Oct 9, 2016 •

edited

Loading

liushuyu commented Nov 8, 2016

BaraMGB commented Nov 8, 2016

BaraMGB commented Jan 27, 2017

tresf commented Jan 27, 2017

zonkmachine commented Jan 28, 2017

BaraMGB commented Feb 8, 2017

zonkmachine commented Feb 8, 2017

tresf commented Feb 9, 2017

BaraMGB commented Jun 1, 2017

zonkmachine commented Oct 31, 2017

improve mouse pointer in piano roll editor #3065

improve mouse pointer in piano roll editor #3065

Conversation

BaraMGB commented Oct 6, 2016

Umcaruje left a comment

Choose a reason for hiding this comment

Umcaruje Oct 7, 2016

Choose a reason for hiding this comment

Umcaruje Oct 7, 2016

Choose a reason for hiding this comment

Umcaruje Oct 7, 2016

Choose a reason for hiding this comment

Umcaruje commented Oct 7, 2016

Umcaruje commented Oct 7, 2016

BaraMGB commented Oct 7, 2016

Umcaruje Oct 8, 2016 • edited Loading

Choose a reason for hiding this comment

BaraMGB commented Oct 8, 2016

tresf commented Oct 9, 2016 • edited Loading

BaraMGB commented Oct 9, 2016 • edited Loading

liushuyu commented Nov 8, 2016

BaraMGB commented Nov 8, 2016

BaraMGB commented Jan 27, 2017

tresf commented Jan 27, 2017

zonkmachine commented Jan 28, 2017

BaraMGB commented Feb 8, 2017

zonkmachine commented Feb 8, 2017

tresf commented Feb 9, 2017

BaraMGB commented Jun 1, 2017

zonkmachine commented Oct 31, 2017

Umcaruje Oct 8, 2016 •

edited

Loading

tresf commented Oct 9, 2016 •

edited

Loading

BaraMGB commented Oct 9, 2016 •

edited

Loading