Prevent BBEditor step stretching

[tresf]

Per request HDDigitizerMusic#1

Before:

After:

The only code that was changed was the removal of the manual scaling logic in the paintEvent function.

[Spekular]

What determines how much they stretch/where they stop? Dealing with long loops pretty much requires you to stretch the steps out. Also, isn't it perhaps better to align the shorter pattern to the left? I'd go so far as saying it's best to just force all patterns to be the same length.

[tresf]

Also, isn't it perhaps better to align the shorter pattern to the left?

That is probably more accurate, but the BBeditor resizes them by width currently, so I believe the spacing logic would still be needed unless we disable resizing.

I'd go so far as saying it's best to just force all patterns to be the same
length.

What happens when a PianoRoll goes over the step length, does it just add another bar?

[tresf]

What determines how much they stretch/where they stop?

There's currently no support for a horizontal scrollbar in the BBEditor (not yet at least), so the stretch is solely determined on the width of the BBEditor.

[Spekular]

For my question on scaling, I meant the steps on the first row are wider than the ones on the bottom, and I was wondering what determined that size. As for piano roll, I think it should be limited to the length of the pattern of possible, or add more bars as you suggested.

[tresf]

I was wondering what determined [max step] size.

This determines the natural step size:
https://github.com/LMMS/lmms/blob/master/data/themes/default/step_btn_on.png

I had to leave the natural shrinking behavior in there or else the resizing of BBEditor would hide the notes on the end (which may be warranted if we had a scroll bar).

As for piano roll, I think it should be limited to the length of the
pattern of possible, or add more bars as you suggested.

Yeah we're reinventing the Song Editor if we do that. Hmm...

[tresf]

Closing for now. This will require much more reworking.

[IvanMaldonado]

Why not just locking a standard size? and then make it as twice as big when more steps are added and so on.

inb4 That's what FL does.

[tresf]

@IvanMaldonado your conversation is likely to be ignored here as this is now a dead pull request. Please take the conversation over to #2636. 👍

inb4 That's what FL does.

Except that comment, that can stay and die in this thread. 😆