Midi import: various small improvements #2006

softrabbit · 2015-04-24T19:54:36Z

A little mixed bag of short modifications here, longer descriptions are with their respective commits.

Don't call AutomationPattern::addObject all the time
Ensure minimum note length 1 tick
Add naming of AutomationTracks
Call qApp->processEvents() before creating tracks (as @Wallacoloo hinted, Midi Import hang #1971 (comment))
Set pitch bend range to 2 semitones on instrument load, GM compatible (half of issue MIDI import: Pitch bend range CCs ignored and wrong default #1967)

Wallacoloo · 2015-04-27T01:29:18Z

plugins/MidiImport/MidiImport.cpp

@@ -394,8 +401,8 @@ bool MidiImport::readSMF( TrackContainer* tc )
 			{
 				smfMidiChannel * ch = chs[evt->chan].create( tc, trackName );
 				Alg_note_ptr noteEvt = dynamic_cast<Alg_note_ptr>( evt );
-
-				Note n( noteEvt->get_duration() * ticksPerBeat,
+				double ticks = MidiTime( noteEvt->get_duration() * ticksPerBeat );


Why is ticks declared as double instead of int? MidiTime only offers an int() cast operator, so casting to double should not give any benefit.

Aimed for the least possible change here. noteEvt->get_duration() returns a double, so there was a double going in to the constructor before.

Wallacoloo · 2015-04-27T22:35:10Z

Just built your branch, and attempting to import "Sylver - Love is an Angel" from http://www.eurokdj.com/ringtones/index_midis.php reliably results in a crash, whereas it works with only warnings in master from a few days ago (edit: it works in current master as well):

FlpImport::tryImport(): not a valid FL project

Error reading song: song node not found
MidiImport::tryImport(): found MThd
MISSING GLOBAL THINGY
lmms: /home/colin/proj/lmms/plugins/MidiImport/portsmf/allegro.cpp:555: char *Alg_event::get_atom_value(): Assertion `get_update_type() == 'a'' failed.
Aborted (core dumped)

v.s. expected output:

FlpImport::tryImport(): not a valid FL project

Error reading song: song node not found
MidiImport::tryImport(): found MThd
MISSING GLOBAL HANDLER
     Chn: -1, Type Code: 9, Time: 0.000000, Update Type: sysexs
fluidsynth: error: There is no preset with bank number 0 and preset number 38 in SoundFont 0
fluidsynth: error: There is no preset with bank number 0 and preset number 80 in SoundFont 0
fluidsynth: error: There is no preset with bank number 0 and preset number 64 in SoundFont 0
fluidsynth: error: There is no preset with bank number 0 and preset number 81 in SoundFont 0
fluidsynth: error: There is no preset with bank number 0 and preset number 119 in SoundFont 0
fluidsynth: error: There is no preset with bank number 128 and preset number 0 in SoundFont 0

Note that I don't have any soundfonts installed (I've never used midi in lmms before).

Wallacoloo · 2015-04-27T22:36:56Z

Also, I'd recommend that you add some inline documentation explaining why the code calls qApp->processEvents() if it's not too much trouble. Might be useful if imports are ever refactored to be threaded separately.

softrabbit · 2015-04-28T08:20:28Z

@Wallacoloo, #1984 is the fix for that crash. Left my variant of that code out of this as that part was taken care of elsewhere. Guess I could rebase this now.

Should be enough to add the object to the automation pattern only once, as the objModel variable that is added will always be the same for the same value of ccid, which indexes the ccs array. This will speed up creation of automation tracks for MIDI CCs and pitch bend.

Too short notes had their duration rounded down to 0 on import, as MIDI precision allows way shorter notes than LMMS, and portsmf reports the duration as a double, where a beat == 1.0. Was going to use ceil() first, but that might round some notes up to a slightly longer duration.

Name the automation tracks like "[MIDI trackname] CC ##". And don't call the automation track creation function for every CC event, as it now will involve constructing a QString.

This should keep LMMS responsive from the window managers POV, unless the user selects a huge enough default sound font that loading it takes too long.

AFAIK, this is how the General MIDI standard says it should be.

changed an odd type juggling into something slightly saner.

…n tracks

softrabbit · 2015-05-18T19:18:25Z

Added a few tweaks suggested by @midi-pascal and @tresf on the lmms-dev mailing list.

midi-pascal · 2015-06-17T17:46:39Z

This would be very nice to have this PR integrated to the master branch.
I use it a lot and it works like a charm.
@tresf Do you think it is feasible since this PR has no side effect?

tresf · 2015-06-17T19:48:23Z

@tresf Do you think it is feasible since this PR has no side effect?

Absolutely, merged. Added to changelog.

FYI, @softrabbit has the ability to merge his own, so this is more a matter of waiting on peer review.

Midi import: various small improvements

softrabbit · 2015-06-17T21:45:10Z

FYI, @softrabbit has the ability to merge his own, so this is more a matter of waiting on peer review.

Are you sure? I always get the text "Only those with write access to this repository can merge pull requests." and no obvious way to merge, so I've assumed that's the way it's meant to be.

tresf · 2015-06-17T22:03:28Z

Are you sure? I always get the text "Only those with write access to this repository can merge pull requests." and no obvious way to merge, so I've assumed that's the way it's meant to be.

Sorry. Fixed. :)

FYI, @softrabbit NOW has the ability to merge his own~~, so this is more a matter of waiting on peer review.~~

midi-pascal · 2015-06-18T01:59:22Z

Wonderfull 👍

Wallacoloo reviewed Apr 27, 2015
View reviewed changes

softrabbit added 5 commits May 5, 2015 12:25

MIDI import: add naming of AutomationTracks

61ab0ed

Name the automation tracks like "[MIDI trackname] CC ##". And don't call the automation track creation function for every CC event, as it now will involve constructing a QString.

MIDI import: call qApp->processEvents(); before creating tracks

06d8717

This should keep LMMS responsive from the window managers POV, unless the user selects a huge enough default sound font that loading it takes too long.

MIDI import: set default pitch bend range to +/-2 semitones

542250e

AFAIK, this is how the General MIDI standard says it should be.

softrabbit force-pushed the midi_import branch from 30581ca to 542250e Compare May 5, 2015 09:26

softrabbit added 2 commits May 5, 2015 22:21

Clarified the reason for qApp->processEvents(),

22b1e4f

changed an odd type juggling into something slightly saner.

MIDI import: i18n in default track names, control names for automatio…

c4f4fe3

…n tracks

tresf added a commit that referenced this pull request Jun 17, 2015

Merge pull request #2006 from softrabbit/midi_import

05d4b13

Midi import: various small improvements

tresf merged commit 05d4b13 into LMMS:master Jun 17, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Midi import: various small improvements #2006

Midi import: various small improvements #2006

softrabbit commented Apr 24, 2015

Wallacoloo Apr 27, 2015

softrabbit Apr 27, 2015

Wallacoloo commented Apr 27, 2015

Wallacoloo commented Apr 27, 2015

softrabbit commented Apr 28, 2015

softrabbit commented May 18, 2015

midi-pascal commented Jun 17, 2015

tresf commented Jun 17, 2015

softrabbit commented Jun 17, 2015

tresf commented Jun 17, 2015

midi-pascal commented Jun 18, 2015

Midi import: various small improvements #2006

Midi import: various small improvements #2006

Conversation

softrabbit commented Apr 24, 2015

Wallacoloo Apr 27, 2015

Choose a reason for hiding this comment

softrabbit Apr 27, 2015

Choose a reason for hiding this comment

Wallacoloo commented Apr 27, 2015

Wallacoloo commented Apr 27, 2015

softrabbit commented Apr 28, 2015

softrabbit commented May 18, 2015

midi-pascal commented Jun 17, 2015

tresf commented Jun 17, 2015

softrabbit commented Jun 17, 2015

tresf commented Jun 17, 2015

midi-pascal commented Jun 18, 2015