Proposed fix 1416 Drag-and-drop of automatables to Automation Editor #1677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2220,6 +2222,7 @@ AutomationEditorWindow::AutomationEditorWindow() : | |||
| setFocusPolicy( Qt::StrongFocus ); | |||
| setFocus(); | |||
| setWindowIcon( embed::getIconPixmap( "automation" ) ); | |||
| setAcceptDrops( true ); | |||
There was a problem hiding this comment.
Nitpicking here... it appears we generally link the toolbar as well per BBEditor.cpp#L56
|
Removed to code that only linked one controller, linked to toolbar, and minor reformatting |
|
This looks great. One possible wish... The display doesn't seem to update properly when dragged directly in. The window needs to be closed and reopened in order to refresh properly.
should look like
|
Sorted :) |
|
Nice one @curlymorphic! As always :-) |
|
Clean and simple. Merging. Thanks! |
tresf
added a commit
that referenced
this pull request
Jan 23, 2015
Proposed fix 1416 Drag-and-drop of automatables to Automation Editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix #1416 Drag-and-drop of automatables to Automation Editor