Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide windows instead of closing them when clicking on close #1495

Merged
merged 1 commit into from
Jan 4, 2015
Merged

Hide windows instead of closing them when clicking on close #1495

merged 1 commit into from
Jan 4, 2015

Conversation

DanWin
Copy link
Contributor

@DanWin DanWin commented Dec 24, 2014

This implements event handlers to prevent the windows from being closed and hiding them instead. There is a difference between closing and hiding a window. When you close a window and open a project where this window is visible, it is empty, or in case of the FXMixerView, only displays the title bar. You can reproduce this by opening lmms, closing all windows and opening any project. All windows will be blank.

@Sti2nd
Copy link
Contributor

Sti2nd commented Dec 27, 2014

What is the difference between hide and close?

Remember that pressing Ctrl + Tab let you select the different open windows, and pressing the key combo several times scroll through the open windows. I hope hiding and closing will be irrelevant for this (Qt) shortcut.

@DanWin
Copy link
Contributor Author

DanWin commented Dec 27, 2014

It only affects the sub-windows in the QMidArea of LMMS, not the OS Window.
Close seams to do a bit more than only hiding a widget, which is what we want and is already done when clicking on the appropriate icon in the toolbar. For a more detailed discussion, see here: http://stackoverflow.com/questions/2293373/what-happens-when-i-call-qwidget-close

@Sti2nd
Copy link
Contributor

Sti2nd commented Dec 27, 2014

not the OS Window.

That is Alt + Tab. Ctrl + Tab is reserved for programs. I just wanted you to make sure you can still use the shortcut. I am not technical enough, yet, to build my own builds.

@DanWin
Copy link
Contributor Author

DanWin commented Dec 27, 2014

Oh, Ctrl not Alt. Thanks for the new shortcut. This shouldn't be affected. You can try it out by clicking on the icons on the top left to hide a window and show it again. It is working almost the same. The only difference is, that the window below is focused instead of no focus/focus on the closed window.

diizy added a commit that referenced this pull request Jan 4, 2015
Hide windows instead of closing them when clicking on close
@diizy diizy merged commit d01c8f2 into LMMS:master Jan 4, 2015
@DanWin DanWin deleted the window branch January 4, 2015 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants