Improve search field

[Sti2nd]

WOW. LMMS got a search field at the bottom of the tree view in the Sidebar? I finally found out... It kinda sucks though, it only search for visible text, not files in folders.

So nr.1 wanted improvement is the ability to search inside folders and subfolders.

And then we have loosely discussed a search function here #614 Which summed up also adds tags as a possibility to list samples and presets.

Edited 2014-11-10 @tresf, added screenshot

[musikBear]

in think it search every -opend- folder, but sadly not subfolders, in an opend folder, but the context-search is absolutely super! If you just found that rigt now, then observe that you have token search!!!
For instance, If you have an instrument named
shortSuperSawNr3
The search will find that if you search for any of sup, saw, nr3, you do -not- have to remember like first 3 letters. Thats wonderfull. I use it to set families of instruments : _sa will display any and all saws (if the folders are opend, that is :)

[eagles051387]

This shouldnt be too hard to fix. If what you are saying is accurate what
its doing is a non recursive search and not searching through folders which
are not open.

On Fri, May 23, 2014 at 1:21 PM, musikBear notifications@github.com wrote:

in think it search every -opend- folder, but sadly not subfolders, in an
opend folder, but the context-search is absolutely super! If you just
found that rigt now, then observe that you have token search!!!
For instance, If you have an instrument named
shortSuperSawNr3
The search will find that if you search for any of sup, saw, nr3, you do
-not- have to remember like first 3 letters. Thats wonderfull. I use it to
set families of instruments : _sa will display any and all saws (if the
folders are opend, that is :)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/760#issuecomment-43996771
.

Jonathan Aquilina

[lukas-w]

@eagles051387
While a recursive search would not be hard to implement – please do! – it may be slow. We should consider indexing the file trees.

[Sti2nd]

Huh, 1.0.100 search the folders too. Don't know who implemented this, thanks. Close?

[lukas-w]

@Sti2nd It doesn't for me. It only searches in folders I already opened.

[Sti2nd]

Oh, they were stored in memory somewhere. Had opened all the preset folders and searched for sweep, then closed them all and searched for sweep again, and it filtered out all the other presets and folders except the two with sweeps presets in them.

[badosu]

@curlymorphic Did your latest patches in this area address this issue? Or is there still something to be improved?

[tresf]

It works and works well, but it doesn't auto-expand search results. Closing since that's really what is being requested. We can allow users to open another one to do tree expansion.

[badosu]

I don't understand, @tresf, if @curlymorphic changes did not solve this issue, why close it?

[tresf]

@badosu they did. The nice-to-have is to auto-expand the search results, which was never part of this request.

[badosu]

@tresf Oh, fine.