Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absolute plugin path gets compiled into binary #42

Closed
lukas-w opened this issue Jan 17, 2014 · 1 comment
Closed

Absolute plugin path gets compiled into binary #42

lukas-w opened this issue Jan 17, 2014 · 1 comment
Labels

Comments

@lukas-w
Copy link
Member

lukas-w commented Jan 17, 2014

Currently the absolute path to the plugin load directory is compiled into the binary (can be set by running cmake -DCMAKE_INSTALL_PREFIX=…)

This has two implications:

  1. Moving the lmms installation to a different location on the file system is not possible without recompiling. (Without recompiling errors such in Building LMMS errors #32 may occur)
  2. After building, installing lmms to a different prefix than previously specified through cmake also requires a recompile.

LMMS should therefore instead store a path relative to the main executable.

@lukas-w
Copy link
Member Author

lukas-w commented Jan 18, 2014

Maybe it should generally be possible to specify a plugin search path in the settings.

lukas-w added a commit to lukas-w/lmms that referenced this issue Jan 18, 2014
Makes the search path that is compiled into the lmms executable relative.
lukas-w added a commit to lukas-w/lmms that referenced this issue Jan 18, 2014
Makes the search path that is compiled into the lmms executable relative.
tobydox added a commit that referenced this issue Jan 19, 2014
Fix for #42: Make search path for plugins relative
@tobydox tobydox closed this as completed Jan 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants