piano-roll: piano buttons not working when playing a pattern

[eagles051387]

If you play a pattern within the piano roll, clicking any of the pianos button won't play a sound. However, if you hold down the mouse button and move over several (or even one is enough) buttons, the sound is played as expected. If you don't play a pattern, the sound is played in both previously named situations and therefore the piano roll is working as expected in this case.

[tobydox]

I remember that we once implemented this intentionally because of possible side effects with the same notes being played/stopped. I don't know how it would work without these extra checks. For testing purposes try to comment out

https://github.com/LMMS/lmms/blob/stable-0.4/src/gui/piano_roll.cpp#L1795
https://github.com/LMMS/lmms/blob/stable-0.4/src/gui/piano_roll.cpp#L1848

and check whether everything works and there are no new problems.

[diizy]

Well I did this and seems to be fine, when same notes are played they just sound twice as loud. I think we can put this in. If it causes problems we can remove the comments again.

[pgiblock]

I think we need to be careful about this one. I say avoid it for 1.0 unless we have a good way to burn it in.

[diizy]

On 02/20/2014 04:50 AM, Paul Giblock wrote:

I think we need to be careful about this one. I say avoid it for 1.0
unless we have a good way to burn it in.

Well I think it'd be good to commit it in now so we can test it more
easily, and if it causes problems we can just revert it. I only
commented out the lines so it'd be easy to revert.