Scrolls to playhead start when autoscroll disabled

[musikBear]

Edited @tresf per @Sti2nd Feb 2nd

Steps to reproduce

1. Go to Piano Roll and disable autoscroll
2. Scroll the window to the right, so that the playhead cannot be seen.
3. Start and stop

---

cant explain this in text, so
http://youtu.be/H6ftZ2Jfaek
summerized, it shows that piano-roll scrolls toan illogical pos. in respect to the play-head-setting, and behavior.

[Sti2nd]

First of all, the title must be more specific. Second, it is not hard to explain in text. "Window scrolls to where playhead started even when autoscroll is disabled".

Steps to reproduce

• Go to Piano Roll and disable autoscroll
• Scroll the window to the right, so that the playhead cannot be seen.
• Start and stop

[tresf]

I'm not sure this is valid...

@musikBear what about the After stopping keep position setting? Isn't that what you want? Should we assume those that have autoscroll turn off want this to switch automagically?

[musikBear]

what about the After stopping keep position setting? Isn't that what you want?

No, the demo shows a situation where i try to find the notes that goes with a sequence of existing notes, so i want playhead to go back to that pos where the existing notes starts
Iow - i want view-posistion to be independent of playhead-posistion, and that is exactly what "After stopping, go back...." option should do. The view-behavior, in this situation, is not logical.
This is valid alright :p

Should we assume those that have autoscroll turn off want this to switch automagically?

absolutely not, but if autoscroll IS off, then view-posistion should not change at all, nomatter where the playhead is, or start posistion was. Thats exactly the point of this ticket
View jumps, even though autoscroll is OFF!

[Sti2nd]

Auto scrolling is turned off, so it is a littlebit strange indeed. Maybe three modes for the autoscroll button?

[tresf]

@Sti2nd can you please explain?

[Sti2nd]

The reason musikBear consider it a bug is because he turns off autoscrolling and then suspects that no autoscrolling will happen whatsoever, but that isn't the case, as he points out. When you stop the playhead, the window scrolls to where it stops (dependent on the playhead mode)

[tresf]

So the bug should be "autoscroll setting ignored when stop is pressed?"

[tresf]

I'm still confused, doesn't the "after stopping keep position" remedy this? What am I missing? Do we just need saner defaults when auto-scroll is disabled? Shall we assume people want the position marker changed when autoscroll is disabled?

[tresf]

Or is this more of a matter that autoscroll off shouldn't ever change the viewport?

[Sti2nd]

So the bug should be "autoscroll setting ignored when stop is pressed?"

Yes.

Or is this more of a matter that autoscroll off shouldn't ever change the viewport?

Yes

[tresf]

Closing as duplicate of meta-bug Better Playhead Auto-Scroll #2291. Please feel free to comment here if needed.

[Umcaruje]

@midi-pascal could you take a look at this one? Its the same problem we had in your PR:

My opinion is that when autoscroll is off, the song editor should never scroll, in any case. What autoscroll really means is 'follow the playhead'. And as a user, when I turn it off, I expect that the song editor never scrolls back to where the playhead is, regardless of its behavior.

If the setting is one of the other two the song editor scrolls back to where it should (beginning of the song or to the time line respectively).

The thing is, those buttons alter how the playhead behaves, and not the song editor. It should be independent.

It appears to be the same thing, but inside the pianoroll.

[midi-pascal]

@Umcaruje Sure. I will check this one.

[midi-pascal]

@Umcaruje Very easy to fix this one: 1 line of code! 😄

[midi-pascal]

@Umcaruje Merge?

[Umcaruje]

@midi-pascal make a PR?

[midi-pascal]

@Umcaruje Oups! Done #2750 😉

[Umcaruje]

Merged 👍 Amazing work @midi-pascal 🍻

[musikBear]

@midi-pascal Big 🍰 from Denmark