Skip to content

Commit

Permalink
Revert "Fix RemoteVstPlugin not exiting when effect removed"
Browse files Browse the repository at this point in the history
This reverts commit eb560a7.
  • Loading branch information
PhysSong committed Apr 29, 2018
1 parent 4d27863 commit 96d6288
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions plugins/VstEffect/VstEffectControlDialog.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ VstEffectControlDialog::VstEffectControlDialog( VstEffectControls * _ctl ) :
if( _ctl != NULL && _ctl->m_effect != NULL &&
_ctl->m_effect->m_plugin != NULL )
{
m_plugin = _ctl->m_effect->m_plugin.data();
m_plugin = _ctl->m_effect->m_plugin;
embed_vst = m_plugin->embedMethod() != "none";

if (embed_vst) {
Expand All @@ -83,7 +83,7 @@ VstEffectControlDialog::VstEffectControlDialog( VstEffectControls * _ctl ) :
SLOT( togglePluginUI( bool ) ) );
} else {
connect( btn, SIGNAL( clicked() ),
m_plugin, SLOT( toggleUI() ) );
m_plugin.data(), SLOT( toggleUI() ) );
}

btn->setMinimumWidth( 78 );
Expand Down
4 changes: 2 additions & 2 deletions plugins/VstEffect/VstEffectControlDialog.h
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
#include <QObject>
#include <QPainter>
#include <QLabel>
#include <QPointer>
#include <QSharedPointer>


class VstEffectControls;
Expand Down Expand Up @@ -61,7 +61,7 @@ class VstEffectControlDialog : public EffectControlDialog
PixmapButton * m_managePluginButton;
PixmapButton * m_savePresetButton;

QPointer<VstPlugin> m_plugin;
QSharedPointer<VstPlugin> m_plugin;

QLabel * tbLabel;

Expand Down

0 comments on commit 96d6288

Please sign in to comment.