Add the isort tool to the test suite
#65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add isort to the test configuration for the project with some sensible defaults.
This ensures the project passes the new test configuration.
|
This looks great, thanks @mcdonnnj ! I haven't used isort before, good to know it's there! In more recent years, I've adopted this styling, but clearly didn't go back to everything to update the various imports. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the isort tool to the test suite for the project. This will ensure that imports in the project are automatically sorted and there is a clear separation between different types of imports (standard library/third-party/internal). This would just improve the maintainability of the code base by keep imports organized and ensuring there is no overlap or duplication.