Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new dependency subpage #388

Merged
merged 2 commits into from
Jul 22, 2020
Merged

Conversation

aidan-epperly
Copy link
Member

Per Ian's idea, this pr adds a new subpage to the explore tab and moves the dependency graph to that page. The dependency graph also now has new features that make it easier to understand and interact with:
image

Please let me know if I have made any errors in the editing of the html, I am not all that familiar with it.

Closes #368 in favor of working on other issues.

@aidan-epperly aidan-epperly requested a review from a team as a code owner July 22, 2020 20:58
@aidan-epperly
Copy link
Member Author

Also, I did not remove force_graph.js as the code still has the settings that allow it to fit normally in the explore page. I can remove it, but I feel that it would be important for that to be it's own commit at least.

js/explore/force_dependencyGraph.js Outdated Show resolved Hide resolved
js/explore/force_graph.js Outdated Show resolved Hide resolved
@aidan-epperly
Copy link
Member Author

Spelling is and always has been my worst subject

@aidan-epperly aidan-epperly requested a review from LRWeber July 22, 2020 22:01
@LRWeber
Copy link
Member

LRWeber commented Jul 22, 2020

Spelling is and always has been my worst subject

Never been my strong suit either.... Which is exactly why I added a spell checker extension to my VS Code setup! I'd rarely catch these things without it. 😅

@LRWeber LRWeber merged commit 4681bce into LLNL:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add repo dependency graph
2 participants