-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency graph #376
Dependency graph #376
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll want to run your Python code through the black
formatter for it to pass the Travis CI checks.
Yes, I just figured that out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to update the dependency requirements to ensure use of the latest scraper version.
llnl-scraper>=0.7.0 |
Should be
llnl-scraper>=0.9.0
|
||
ghDataDir = env.get("GITHUB_DATA", "../github-data") | ||
datfilepath = "%s/labRepos_Dependencies.json" % ghDataDir | ||
queryPath = "../queries/repo-dependencies.gql" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nitpicking detail, but could we change the repo-dependencies.gql
filename to repo-Dependencies.gql
? Just so that the naming scheme matches the other query files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the actual path here still needs to be changed to match the re-named file.
The new commits that I made don't seem to syncing on this page, but when I go to try and make a pr from the same branch, it has this one there and the commits are listed. Hmm |
This pull request satisfies the dependency graph from #368 by adding a new query, data file, and visualization. I know that there are probably things that I should change, but I figured it would be good to get the PR in now so that people could catch errors or problems now.
Here is the graph in it's current form:
Every node and link has a title that appears on mouseover.