Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency graph #376

Closed
wants to merge 7 commits into from
Closed

Conversation

aidan-epperly
Copy link
Member

This pull request satisfies the dependency graph from #368 by adding a new query, data file, and visualization. I know that there are probably things that I should change, but I figured it would be good to get the PR in now so that people could catch errors or problems now.

Here is the graph in it's current form:
image

Every node and link has a title that appears on mouseover.

@aidan-epperly aidan-epperly requested review from IanLee1521, LRWeber and a team as code owners July 14, 2020 22:28
@LRWeber LRWeber marked this pull request as draft July 14, 2020 22:30
Copy link
Member

@LRWeber LRWeber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to run your Python code through the black formatter for it to pass the Travis CI checks.

@aidan-epperly
Copy link
Member Author

You'll want to run your Python code through the black formatter for it to pass the Travis CI checks.

Yes, I just figured that out.

Copy link
Member

@LRWeber LRWeber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to update the dependency requirements to ensure use of the latest scraper version.


Should be llnl-scraper>=0.9.0


ghDataDir = env.get("GITHUB_DATA", "../github-data")
datfilepath = "%s/labRepos_Dependencies.json" % ghDataDir
queryPath = "../queries/repo-dependencies.gql"
Copy link
Member

@LRWeber LRWeber Jul 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpicking detail, but could we change the repo-dependencies.gql filename to repo-Dependencies.gql? Just so that the naming scheme matches the other query files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the actual path here still needs to be changed to match the re-named file.

@aidan-epperly
Copy link
Member Author

New color scheme:
image

@aidan-epperly aidan-epperly marked this pull request as ready for review July 15, 2020 15:25
@aidan-epperly
Copy link
Member Author

The new commits that I made don't seem to syncing on this page, but when I go to try and make a pr from the same branch, it has this one there and the commits are listed. Hmm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants