CHAI_LOG only active with CHAI_DEBUG regardless of RM being enabled #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
I would rather this be a runtime option, because otherwise people will compile with it turned off and it makes it difficult to help debug issues. Can we maybe remove the messages you were seeing cause a lot of overhead? |
…configuration options for disable WARN logging and all logging, refactor logging of movements to only occur when a move occurs
liu15
reviewed
Apr 11, 2025
| @@ -70,23 +70,33 @@ | |||
|
|
|||
| #define CHAI_UNUSED_ARG(X) | |||
|
|
|||
| #if !defined(CHAI_DISABLE_ALL_LOGGING) | |||
| #if !defined(CHAI_DISABLE_RM) | |||
There was a problem hiding this comment.
Should this still be disabled if the resource manager is disabled? Umpire is required either way, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this was intentional or not, but CHAI_LOG has been incurring overhead for non debug builds. This has shown up in some of CARE's stress testing kernel launch overhead (can double the cost of a kernel capture and launch). This PR changes CHAI_LOG to only do something when CHAI_DEBUG is defined.