Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Musig2 key aggregation #67

Closed
wants to merge 2 commits into from
Closed

Conversation

RCasatta
Copy link

@RCasatta RCasatta commented Jul 23, 2021

super draft status

Wanted to try to implement https://github.com/ElementsProject/secp256k1-zkp/blob/master/src/modules/musig/musig-spec.mediawiki

Test vectors are currently passing, however, spec may change BlockstreamResearch/secp256k1-zkp#120 (comment)

@LLFourn
Copy link
Owner

LLFourn commented Jul 26, 2021

Nice. I think this belongs in schnorr_fun eventually. This would be the first multi-party protocol in the *_fun crates and I have no idea what the API should be like so interested to know if you have some further ideas. I also need this by November for my own schemes!

@RCasatta RCasatta changed the title test musig2_fun Musig2 key aggregation Jul 26, 2021
@RCasatta
Copy link
Author

RCasatta commented Jul 26, 2021

I think this belongs in schnorr_fun eventually.

Moved into schnorr_fun and removed some TODOs, a little less drafty, however, spec may change BlockstreamResearch/secp256k1-zkp#120 (comment)

I have no idea what the API should be like so interested to know if you have some further ideas

At the moment I am trying to get a deeper understanding by playing around to have some ideas

I see BlockstreamResearch/secp256k1-zkp#131 (comment) is what Nicolas come up in C#

I also need this by November for my own schemes!

November is coming!

@LLFourn
Copy link
Owner

LLFourn commented Jan 12, 2022

This is superseded by #80

Thanks for doing this @RCasatta. I used the test case you developed here for the new PR. If you have time to review, please let me know what you think of the API etc.

@LLFourn LLFourn closed this Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants