fix: undefined tokenId #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sues-with-sdk-utility-method
| @@ -1903,10 +1903,14 @@ https://developer.litprotocol.com/v3/sdk/wallets/auth-methods/#auth-method-scope | |||
| for (let i = 0; i < tokenIds.length; i++) { | |||
| const tokenId = tokenIds[i]; | |||
| const pubKey = await this.pkpNftContract.read.getPubkey(tokenId); | |||
| const addrs = await derivedAddresses({ | |||
| const addrs: TokenInfo = await derivedAddresses({ | |||
There was a problem hiding this comment.
Probably should make the tokenId optional in TokenInfo to keep Typescript consistency. This way we can also remove the any in derivedAddresses return type TokenInfo | any
FedericoAmura
approved these changes
Dec 17, 2024
…sues-with-sdk-utility-method
…sues-with-sdk-utility-method
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
When calling the
contractClient.pkpNftContractUtils.read.getTokensInfoByAddressfunction,tokenIdis returningundefined. This little fix added a check to ensure addrs.tokenId is assigned a value if it’s missing. If thederivedAddressesfunction doesn’t return atokenId, thetokenIdfrom the context (tokenId) is used as a fallback.