-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow cert caching if local storage is defined #437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! e2e seems to be failing though with your cert test
❌ 1 test(s) failed
-------------------
- [1] Error happened in /home/runner/work/js-sdk/js-sdk/e2e-nodejs/group-connection/test-connection-cert-caching.mjs, see below for details 👇
Error: missing revert data in call exception; Transaction reverted without a reason string [ See: https://links.ethers.org/v5-errors-CALL_EXCEPTION ] (data="0x", transaction={"to":"0xBC7F8d7864002b6629Ab49781D5199C8dD1DDcE1","data":"0x43cb0a0e","accessList":null}, error={"reason":"missing response","code":"SERVER_ERROR","requestBody":"{\"method\":\"eth_call\",\"params\":[{\"to\":\"0xbc7f8d7864002b6629ab49781d5199c8dd1ddce1\",\"data\":\"0x43cb0a0e\"},\"latest\"],\"id\":45,\"jsonrpc\":\"2.0\"}","requestMethod":"POST","serverError":{"errno":-104,"code":"ECONNRESET","syscall":"read"},"url":"https://chain-rpc.litprotocol.com/http"}, code=CALL_EXCEPTION, version=providers/5.7.2)
Did a re run of that job since the error looked to be an rpc timeout issue. The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good - just the one change in the test so that when we start supporting Genoa, or if the AMD URL path changes, the test doesn't break.
@glitch003 |
Description
Changes a conditional check for storing AMD SEV SNP certificates in
localstorage
to now check if the api is available rather than doing a check for a browser environment. this will allow for caching in local storage in non browser environments if the api is available.Type of change
How Has This Been Tested?
A new
connection
e2e test has been added which defines alocalstorage
provider and checks that certs have been cached afterconnect
finishes.Checklist: