-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth Unification, Custom Auths, better tests #435
Merged
joshLong145
merged 156 commits into
staging/v6
from
feature/lit-2958-auth-unification-ts-tests
May 10, 2024
Merged
Auth Unification, Custom Auths, better tests #435
joshLong145
merged 156 commits into
staging/v6
from
feature/lit-2958-auth-unification-ts-tests
May 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… functions, and fix circular dependencies inside auth-helpers
…ededCallbacks, and a higher level "getPkpSessionSigs" function
Ansonhkg
requested review from
jtary,
glitch003,
hwrdtm,
FedericoAmura,
joshLong145,
MaximusHaximus and
DashKash54
April 23, 2024 17:16
… LIT_CURVE, and a util for sanitise //
15 tasks
joshLong145
reviewed
Apr 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments going to do another pass
…ate the delegation auth sig
…twork-bootstrap Feature/lit 3173 cayenne network bootstrap
12 tasks
…nd migrated old tests to .ts
Fix/pkp ethers
Ansonhkg
changed the title
[STAGING] BREAKING - Auth Unification
[6.0] Staging - Auth Unification, Custom Auths, better tests
May 10, 2024
…ure/lit-2958-auth-unification-ts-tests
joshLong145
changed the title
[6.0] Staging - Auth Unification, Custom Auths, better tests
Auth Unification, Custom Auths, better tests
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces Tinny, an improved mini e2e testing framework that allows us to write tests in TypeScript. It leverages
esbuild
for rapid test compilation and execution. Tinny includes typed test helper functions to generate new identities within tests, and provides APIs to modify the development environment.See docs:
https://github.com/LIT-Protocol/js-sdk/tree/feature/lit-2958-auth-unification-ts-tests/local-tests
Note
We are not merging this PR to master until all related PRs are merged to this branch.
Cherry Picked:
We should also raise a PR to remove all existing V0 features when we are ready to deploy. They are now being tracked here
Changes
siweMessage
creation andauthSig
crafting, addressing circular dependencies in theauth-helpers
package.authNeededCallbacks
to support additional parameters and introduced a - higher-level function,getPkpSessionSigs
, to streamline PKP sessionSigs creation process.Type of change
How Has This Been Tested?
Screen.Recording.2024-04-23.at.23.26.00.mov
Checklist: